Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2968973002: [ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE

Created:
3 years, 5 months ago by marq (ping after 24h)
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE BUG=738881, 228521

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -43 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 4 chunks +16 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 4 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/commands/browser_commands.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/key_commands_provider.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 1 3 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 1 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 1 4 chunks +12 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm View 3 chunks +3 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (9 generated)
marq (ping after 24h)
3 years, 5 months ago (2017-07-04 14:27:22 UTC) #6
Rebased

Powered by Google App Engine
This is Rietveld 408576698