[ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE

ios/chrome/browser/ui/browser_view_controller_unittest.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 #import <PassKit/PassKit.h>
 
 #include <memory>
 
 #include "base/command_line.h"
@@ skipping 15 matching lines @@
 #include "ios/chrome/browser/search_engines/template_url_service_factory.h"
 #include "ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/ui/activity_services/share_protocol.h"
 #import "ios/chrome/browser/ui/activity_services/share_to_data.h"
 #import "ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h"
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 #import "ios/chrome/browser/ui/browser_view_controller_dependency_factory.h"
 #import "ios/chrome/browser/ui/browser_view_controller_testing.h"
+#import "ios/chrome/browser/ui/commands/browser_commands.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #import "ios/chrome/browser/ui/ntp/new_tab_page_controller.h"
 #import "ios/chrome/browser/ui/page_not_available_controller.h"
 #include "ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.h"
 #import "ios/chrome/browser/ui/toolbar/web_toolbar_controller.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/browser/web/error_page_content.h"
 #import "ios/chrome/browser/web/passkit_dialog_provider.h"
 #include "ios/chrome/browser/web_state_list/fake_web_state_list_delegate.h"
@@ skipping 376 matching lines @@
   // Have the TestToolbarModel indicate that the page load is complete.
   static_cast<TestToolbarModelIOS*>(toolbarModelIOS_)->set_is_loading(false);
 
   // Don't set any expectation for stopLoading to be called on the mock tab.
   [bvc_ locationBarBeganEdit:nil];
 
   EXPECT_OCMOCK_VERIFY(tabMock);
 }
 
 // Verifies that BVC invokes -shareURL on ShareController with the correct
-// parameters in response to the IDC_SHARE_PAGE command.
+// parameters in response to the -sharePage command.
 TEST_F(BrowserViewControllerTest, TestSharePageCommandHandling) {
   GURL expectedUrl("http://www.testurl.net");
   NSString* expectedTitle = @"title";
   static_cast<BVCTestTabMock*>(tab_).lastCommittedURL = expectedUrl;
   static_cast<BVCTestTabMock*>(tab_).visibleURL = expectedUrl;
   OCMockObject* tabMock = static_cast<OCMockObject*>(tab_);
   ios::ChromeBrowserState* ptr = chrome_browser_state_.get();
   [[[tabMock stub] andReturnValue:OCMOCK_VALUE(ptr)] browserState];
   [[[tabMock stub] andReturn:expectedTitle] title];
   [[[tabMock stub] andReturn:expectedTitle] originalTitle];
@@ skipping 22 matching lines @@
            shareToData.isPagePrintable == NO && thumbnailDataIsEqual;
   };
 
   [[shareControllerMock expect]
         shareWithData:[OCMArg checkWithBlock:shareDataChecker]
            controller:bvc_
          browserState:chrome_browser_state_.get()
       shareToDelegate:bvc_
              fromRect:[bvc_ testing_shareButtonAnchorRect]
                inView:[OCMArg any]];
-  [bvc_ chromeExecuteCommand:GetCommandWithTag(IDC_SHARE_PAGE)];
+  [bvc_.browserCommandDispatcher sharePage];
   EXPECT_OCMOCK_VERIFY(shareControllerMock);
 }
 
 // Verifies that BVC does not invoke -shareURL on ShareController in response
-// to the IDC_SHARE_PAGE command if tab is in the process of being closed.
+// to the |-sharePage| command if tab is in the process of being closed.
 TEST_F(BrowserViewControllerTest, TestSharePageWhenClosing) {
   GURL expectedUrl("http://www.testurl.net");
   NSString* expectedTitle = @"title";
   // Sets WebState to nil because [tab close] clears the WebState.
   static_cast<BVCTestTabMock*>(tab_).webState = nil;
   static_cast<BVCTestTabMock*>(tab_).lastCommittedURL = expectedUrl;
   static_cast<BVCTestTabMock*>(tab_).visibleURL = expectedUrl;
   OCMockObject* tabMock = static_cast<OCMockObject*>(tab_);
   [[[tabMock stub] andReturn:expectedTitle] title];
   [[[tabMock stub] andReturn:expectedTitle] originalTitle];
   // Explicitly disallow the execution of the ShareController.
   OCMockObject* shareControllerMock =
       static_cast<OCMockObject*>(shareController_);
   [[shareControllerMock reject]
         shareWithData:[OCMArg any]
            controller:bvc_
          browserState:chrome_browser_state_.get()
       shareToDelegate:bvc_
              fromRect:[bvc_ testing_shareButtonAnchorRect]
                inView:[OCMArg any]];
-  [bvc_ chromeExecuteCommand:GetCommandWithTag(IDC_SHARE_PAGE)];
+  [bvc_.browserCommandDispatcher sharePage];
   EXPECT_OCMOCK_VERIFY(shareControllerMock);
 }
 
 // Verifies that BVC instantiates a bubble to show the given success message on
 // receiving a -shareDidComplete callback for a successful share.
 TEST_F(BrowserViewControllerTest, TestShareDidCompleteWithSuccess) {
   NSString* completionMessage = @"Completion!";
   [[dependencyFactory_ expect] showSnackbarWithMessage:completionMessage];
 
   [bvc_ shareDidComplete:ShareTo::SHARE_SUCCESS
@@ skipping 66 matching lines @@
       static_cast<OCMockObject*>(shareController_);
   [[shareControllerMock expect] cancelShareAnimated:NO];
   EXPECT_CALL(*this, OnCompletionCalled());
   [bvc_ clearPresentedStateWithCompletion:^{
     this->OnCompletionCalled();
   }];
   EXPECT_OCMOCK_VERIFY(shareControllerMock);
 }
 
 }  // namespace