Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2968973002: [ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE
Patch Set: Rebased Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/browser_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 51b66e9dbe616be6f0364e6d862939be42747172..4fd3d63b88e450d63134275319b6b13a020c7855 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -4043,6 +4043,21 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
}
}
+- (void)sharePage {
+ ShareToData* data = activity_services::ShareToDataForTab([_model currentTab]);
+ if (data)
+ [self sharePageWithData:data];
+}
+
+- (void)bookmarkPage {
+ [self initializeBookmarkInteractionController];
+ [_bookmarkInteractionController
+ presentBookmarkForTab:[_model currentTab]
+ currentlyBookmarked:_toolbarModelIOS->IsCurrentTabBookmarkedByUser()
+ inView:[_toolbarController bookmarkButtonView]
+ originRect:[_toolbarController bookmarkButtonAnchorRect]];
+}
+
#pragma mark - Command Handling
- (IBAction)chromeExecuteCommand:(id)sender {
@@ -4053,14 +4068,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
Tab* currentTab = [_model currentTab];
switch (command) {
- case IDC_BOOKMARK_PAGE:
- [self initializeBookmarkInteractionController];
- [_bookmarkInteractionController
- presentBookmarkForTab:[_model currentTab]
- currentlyBookmarked:_toolbarModelIOS->IsCurrentTabBookmarkedByUser()
- inView:[_toolbarController bookmarkButtonView]
- originRect:[_toolbarController bookmarkButtonAnchorRect]];
- break;
case IDC_FIND:
[self initFindBarForTab];
break;
@@ -4116,14 +4123,12 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
[super chromeExecuteCommand:sender];
}
break;
+
case IDC_RELOAD: {
// Route to dispatcher until downstream code is migrated.
[self.browserCommandDispatcher reload];
break;
}
- case IDC_SHARE_PAGE:
- [self sharePage];
- break;
case IDC_SHOW_MAIL_COMPOSER:
[self showMailComposer:sender];
break;
@@ -4247,11 +4252,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
}
}
-- (void)sharePage {
- ShareToData* data = activity_services::ShareToDataForTab([_model currentTab]);
- if (data)
- [self sharePageWithData:data];
-}
- (void)sharePageWithData:(ShareToData*)data {
id<ShareProtocol> controller = [_dependencyFactory shareControllerInstance];
« no previous file with comments | « no previous file | ios/chrome/browser/ui/browser_view_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698