Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: ios/chrome/browser/ui/toolbar/toolbar_controller.mm

Issue 2968973002: [ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE
Patch Set: Rebased Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/toolbar/toolbar_controller.mm
diff --git a/ios/chrome/browser/ui/toolbar/toolbar_controller.mm b/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
index c73073e59332605538f33c9edca02b1d8435feea..d17f1b6dfd064cafd6aef258e3c26ffdce6438be 100644
--- a/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
+++ b/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
@@ -16,7 +16,7 @@
#include "base/metrics/user_metrics_action.h"
#import "ios/chrome/browser/ui/animation_util.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
-#import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
+#import "ios/chrome/browser/ui/commands/browser_commands.h"
#include "ios/chrome/browser/ui/commands/ios_command_ids.h"
#import "ios/chrome/browser/ui/fullscreen_controller.h"
#import "ios/chrome/browser/ui/image_util.h"
@@ -300,7 +300,6 @@ const LayoutOffset kButtonFadeOutXOffset = 10;
if (idiom == IPAD_IDIOM) {
CGRect shareButtonFrame = LayoutRectGetRect(kShareMenuButtonFrame);
shareButton_ = [[UIButton alloc] initWithFrame:shareButtonFrame];
- [shareButton_ setTag:IDC_SHARE_PAGE];
[shareButton_
setAutoresizingMask:UIViewAutoresizingFlexibleLeadingMargin() |
UIViewAutoresizingFlexibleBottomMargin];
@@ -309,6 +308,9 @@ const LayoutOffset kButtonFadeOutXOffset = 10;
forInitialState:UIControlStateNormal
hasDisabledImage:YES
synchronously:NO];
+ [shareButton_ addTarget:self.dispatcher
+ action:@selector(sharePage)
+ forControlEvents:UIControlEventTouchUpInside];
SetA11yLabelAndUiAutomationName(shareButton_, IDS_IOS_TOOLS_MENU_SHARE,
kToolbarShareButtonIdentifier);
[view_ addSubview:shareButton_];
« no previous file with comments | « ios/chrome/browser/ui/key_commands_provider.mm ('k') | ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698