Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2965963002: [ios] Remove IDC_STOP and IDC_RELOAD

Created:
3 years, 5 months ago by marq (ping after 24h)
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, raymes+watch_chromium.org, lgarron+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Remove IDC_STOP and IDC_RELOAD BUG=738881

Patch Set 1 #

Patch Set 2 : Fixed buttons not working. #

Patch Set 3 : Don't break downstream. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -41 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 2 3 5 chunks +18 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/commands/browser_commands.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/key_commands_provider.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/page_info_view_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/page_info_view_controller.mm View 4 chunks +10 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/popup_menu/popup_menu_controller.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h View 3 chunks +10 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 1 5 chunks +26 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_popup_controller.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm View 1 3 chunks +8 lines, -3 lines 0 comments Download
M ios/chrome/browser/web/cache_egtest.mm View 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/test/earl_grey/chrome_earl_grey.mm View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (16 generated)
marq (ping after 24h)
Don't break downstream.
3 years, 5 months ago (2017-07-04 13:07:56 UTC) #9
marq (ping after 24h)
3 years, 5 months ago (2017-07-04 14:09:28 UTC) #14 
Rebased.

Powered by Google App Engine
This is Rietveld 408576698