Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Issue 2968973002: [ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE
Patch Set: Rebased Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
index eb75552b60cdb5e164050b41ff1ff83492765efe..d97221904e36604491370a8927d1c9b3b67da7b3 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
@@ -162,10 +162,10 @@ NS_INLINE UIEdgeInsets TabHistoryPopupMenuInsets() {
- (void)commandWasSelected:(int)commandID {
// Record the corresponding metric.
switch (commandID) {
- case IDC_TEMP_EDIT_BOOKMARK:
+ case TOOLS_BOOKMARK_EDIT:
base::RecordAction(UserMetricsAction("MobileMenuEditBookmark"));
break;
- case IDC_BOOKMARK_PAGE:
+ case TOOLS_BOOKMARK_ITEM:
base::RecordAction(UserMetricsAction("MobileMenuAddToBookmarks"));
break;
case IDC_CLOSE_ALL_TABS:
@@ -192,7 +192,7 @@ NS_INLINE UIEdgeInsets TabHistoryPopupMenuInsets() {
case TOOLS_RELAOD_ITEM:
base::RecordAction(UserMetricsAction("MobileMenuReload"));
break;
- case IDC_SHARE_PAGE:
+ case TOOLS_SHARE_ITEM:
base::RecordAction(UserMetricsAction("MobileMenuShare"));
break;
case IDC_REQUEST_DESKTOP_SITE:
« no previous file with comments | « ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698