Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2965943002: [ios] Remove IDC_BACK and IDC_FORWARD

Created:
3 years, 5 months ago by marq (ping after 24h)
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Remove IDC_BACK and IDC_FORWARD - Adds a dispatcher to ToolbarController. - Adds -goBack and goForward to BrowserCommands. BUG=738881 TEST=Manually tested forward/back in simulator

Patch Set 1 #

Patch Set 2 : Rebase, self review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -68 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 4 chunks +12 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_dependency_factory.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/commands/browser_commands.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/key_commands_provider.mm View 1 3 chunks +28 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm View 1 chunk +7 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/omnibox_perftest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_controller.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 2 chunks +7 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 6 chunks +19 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/web/cache_egtest.mm View 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/browser/web/visible_url_egtest.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M ios/chrome/test/earl_grey/chrome_earl_grey.mm View 1 chunk +4 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (10 generated)
marq (ping after 24h)
3 years, 5 months ago (2017-07-04 09:48:25 UTC) #7
Rebase, self review.

Powered by Google App Engine
This is Rietveld 408576698