Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 2970553002: [ios] Remove IDC_CLOSE_TAB

Created:
3 years, 5 months ago by marq (ping after 24h)
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, tfarina, baxley+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Remove IDC_CLOSE_TAB This CL removes the IDC_CLOSE_TAB command ID and replaces all uses of it with calls to a command dispatcher. In order to do that, the following infrastructural changes are also made: - A BrowserCommands protocol is created that will house all of the ChromeCommands handled by the BVC. - The BVC's _dispatcher is exposed publicly as an id<BrowserCommands> - Various other classes that accepted the BVC's dispatcher have BrowsreCommands added to the protocols that dispatcher conforms to. - An egtest utility to get the dispatcher for the main BVC is added, and will be used to replace calls to RunCommandWithActiveViewController(). BUG=738881 TEST=Manually tested closing tabs.

Patch Set 1 #

Patch Set 2 : Fix unit test. #

Patch Set 3 : Self review. #

Patch Set 4 : Add comment for chrome_test_util.h" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -27 lines) Patch
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm View 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 6 chunks +12 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/commands/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/ui/commands/browser_commands.h View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/key_commands_provider.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/key_commands_provider.mm View 1 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/key_commands_provider_unittest.mm View 1 3 chunks +23 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_view_controller.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_view_controller.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/test/app/chrome_test_util.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/test/app/chrome_test_util.mm View 1 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (11 generated)
marq (ping after 24h)
Fix unit test.
3 years, 5 months ago (2017-07-03 07:38:09 UTC) #5
marq (ping after 24h)
Self review.
3 years, 5 months ago (2017-07-03 09:18:08 UTC) #10
marq (ping after 24h)
3 years, 5 months ago (2017-07-03 09:23:45 UTC) #12
Add comment for chrome_test_util.h"

Powered by Google App Engine
This is Rietveld 408576698