Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: ios/chrome/browser/ui/key_commands_provider_unittest.mm

Issue 2970553002: [ios] Remove IDC_CLOSE_TAB
Patch Set: Add comment for chrome_test_util.h" Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/key_commands_provider_unittest.mm
diff --git a/ios/chrome/browser/ui/key_commands_provider_unittest.mm b/ios/chrome/browser/ui/key_commands_provider_unittest.mm
index b616ce426b458731518501137d7981abb93f01f8..3b49f77f027b61d6c9ee0e92f33adef7494f8780 100644
--- a/ios/chrome/browser/ui/key_commands_provider_unittest.mm
+++ b/ios/chrome/browser/ui/key_commands_provider_unittest.mm
@@ -22,20 +22,25 @@ TEST(KeyCommandsProviderTest, NoTabs_EditingText_ReturnsObjects) {
KeyCommandsProvider* provider = [[KeyCommandsProvider alloc] init];
id mockConsumer =
[OCMockObject mockForProtocol:@protocol(KeyCommandsPlumbing)];
+ id<BrowserCommands> dispatcher = nil;
[[[mockConsumer expect] andReturnUnsignedInteger:0] tabsCount];
- EXPECT_NE(nil,
- [provider keyCommandsForConsumer:mockConsumer editingText:YES]);
+ EXPECT_NE(nil, [provider keyCommandsForConsumer:mockConsumer
+ browserCommandDispatcher:dispatcher
+ editingText:YES]);
}
TEST(KeyCommandsProviderTest, ReturnsKeyCommandsObjects) {
KeyCommandsProvider* provider = [[KeyCommandsProvider alloc] init];
id mockConsumer =
[OCMockObject mockForProtocol:@protocol(KeyCommandsPlumbing)];
+ id<BrowserCommands> dispatcher = nil;
+
[[[mockConsumer expect] andReturnUnsignedInteger:0] tabsCount];
- for (id element in
- [provider keyCommandsForConsumer:mockConsumer editingText:YES]) {
+ for (id element in [provider keyCommandsForConsumer:mockConsumer
+ browserCommandDispatcher:dispatcher
+ editingText:YES]) {
EXPECT_TRUE([element isKindOfClass:[UIKeyCommand class]]);
}
}
@@ -44,16 +49,21 @@ TEST(KeyCommandsProviderTest, MoreKeyboardCommandsWhenTabs) {
KeyCommandsProvider* provider = [[KeyCommandsProvider alloc] init];
id mockConsumer =
[OCMockObject mockForProtocol:@protocol(KeyCommandsPlumbing)];
+ id<BrowserCommands> dispatcher = nil;
// No tabs.
[[[mockConsumer expect] andReturnUnsignedInteger:0] tabsCount];
NSUInteger numberOfKeyCommandsWithoutTabs =
- [[provider keyCommandsForConsumer:mockConsumer editingText:NO] count];
+ [[provider keyCommandsForConsumer:mockConsumer
+ browserCommandDispatcher:dispatcher
+ editingText:NO] count];
// Tabs.
[[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
NSUInteger numberOfKeyCommandsWithTabs =
- [[provider keyCommandsForConsumer:mockConsumer editingText:NO] count];
+ [[provider keyCommandsForConsumer:mockConsumer
+ browserCommandDispatcher:dispatcher
+ editingText:NO] count];
EXPECT_GT(numberOfKeyCommandsWithTabs, numberOfKeyCommandsWithoutTabs);
}
@@ -62,16 +72,21 @@ TEST(KeyCommandsProviderTest, LessKeyCommandsWhenTabsAndEditingText) {
KeyCommandsProvider* provider = [[KeyCommandsProvider alloc] init];
id mockConsumer =
[OCMockObject mockForProtocol:@protocol(KeyCommandsPlumbing)];
+ id<BrowserCommands> dispatcher = nil;
// Not editing text.
[[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
NSUInteger numberOfKeyCommandsWhenNotEditingText =
- [[provider keyCommandsForConsumer:mockConsumer editingText:NO] count];
+ [[provider keyCommandsForConsumer:mockConsumer
+ browserCommandDispatcher:dispatcher
+ editingText:NO] count];
// Editing text.
[[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
NSUInteger numberOfKeyCommandsWhenEditingText =
- [[provider keyCommandsForConsumer:mockConsumer editingText:YES] count];
+ [[provider keyCommandsForConsumer:mockConsumer
+ browserCommandDispatcher:dispatcher
+ editingText:YES] count];
EXPECT_LT(numberOfKeyCommandsWhenEditingText,
numberOfKeyCommandsWhenNotEditingText);
« no previous file with comments | « ios/chrome/browser/ui/key_commands_provider.mm ('k') | ios/chrome/browser/ui/ntp/google_landing_view_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698