ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm - Issue 2970553002: [ios] Remove IDC_CLOSE_TAB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Issue 2970553002: [ios] Remove IDC_CLOSE_TAB

Patch Set: Add comment for chrome_test_util.h" Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h ('k') | ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

diff --git a/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm b/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

index 2d3ee362e0773aee696c5593a0f4f4da7a22acfe..21fbd2369e873920a0e44cf16062f77174e4172c 100644

--- a/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

+++ b/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

@@ -25,6 +25,7 @@

#include "ios/chrome/browser/reading_list/reading_list_model_factory.h"

#import "ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h"

#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"

+#import "ios/chrome/browser/ui/commands/browser_commands.h"

#import "ios/chrome/browser/ui/commands/generic_chrome_command.h"

#include "ios/chrome/browser/ui/commands/ios_command_ids.h"

#import "ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h"

@@ -417,9 +418,7 @@

[self.suggestionsViewController chromeExecuteCommand:command];

} break;

case OverscrollAction::CLOSE_TAB: {

- base::scoped_nsobject<GenericChromeCommand> command(

- [[GenericChromeCommand alloc] initWithTag:IDC_CLOSE_TAB]);

- [self.suggestionsViewController chromeExecuteCommand:command];

+ [_dispatcher closeCurrentTab];

} break;

case OverscrollAction::REFRESH:

[self reload];