Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

Issue 2969103002: [ios] Remove IDC_SHOW_TOOLS_MENU
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
index f66c14459d12d4cd841371cdd32d72e91704ab42..abe82f67886fe3fc2fea75fdc0e3f1b8acbabc4a 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
@@ -489,10 +489,9 @@ NS_INLINE void AnimateInViews(NSArray* views,
// to the real command for the dispatch. This is very hacky, but it will go
// away soon. See crbug/228521
DCHECK([sender respondsToSelector:@selector(setTag:)]);
- // Do nothing when tapping the tools menu a second time.
// Do not use -chromeExecuteCommand: for tags < 0 -- that is, items that have
// been refactored to use the dispatcher.
- if (commandId != IDC_SHOW_TOOLS_MENU && commandId > 0) {
+ if (commandId > 0) {
[self chromeExecuteCommand:sender];
}

Powered by Google App Engine
This is Rietveld 408576698