ios/chrome/browser/ui/key_commands_provider.mm - Issue 2968973002: [ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/key_commands_provider.mm

Issue 2968973002: [ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE

Patch Set: Rebased Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/key_commands_provider.mm

diff --git a/ios/chrome/browser/ui/key_commands_provider.mm b/ios/chrome/browser/ui/key_commands_provider.mm

index e1f85437903639a0cffcf628db5676c42c6b2529..5c2c601b46f54ab4149cf96116f0b575d5d5c93f 100644

--- a/ios/chrome/browser/ui/key_commands_provider.mm

+++ b/ios/chrome/browser/ui/key_commands_provider.mm

@@ -129,7 +129,7 @@

title:l10n_util::GetNSStringWithFixup(

IDS_IOS_KEYBOARD_BOOKMARK_THIS_PAGE)

action:^{

- execute(IDC_BOOKMARK_PAGE);

+ [weakDispatcher bookmarkPage];

}],

[UIKeyCommand cr_keyCommandWithInput:@"f"

modifierFlags:UIKeyModifierCommand