Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ios/chrome/browser/ui/browser_view_controller_unittest.mm

Issue 2968973002: [ios] Removes IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE
Patch Set: Rebased Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | ios/chrome/browser/ui/commands/browser_commands.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller_unittest.mm b/ios/chrome/browser/ui/browser_view_controller_unittest.mm
index 72f2e7336d4e219db0b97ce256191e50440b4d31..62c1a426cb0c44358ef6ce6fc82577201b3c55be 100644
--- a/ios/chrome/browser/ui/browser_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/browser_view_controller_unittest.mm
@@ -33,6 +33,7 @@
#import "ios/chrome/browser/ui/browser_view_controller.h"
#import "ios/chrome/browser/ui/browser_view_controller_dependency_factory.h"
#import "ios/chrome/browser/ui/browser_view_controller_testing.h"
+#import "ios/chrome/browser/ui/commands/browser_commands.h"
#import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
#include "ios/chrome/browser/ui/commands/ios_command_ids.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_controller.h"
@@ -429,7 +430,7 @@ TEST_F(BrowserViewControllerTest,
}
// Verifies that BVC invokes -shareURL on ShareController with the correct
-// parameters in response to the IDC_SHARE_PAGE command.
+// parameters in response to the -sharePage command.
TEST_F(BrowserViewControllerTest, TestSharePageCommandHandling) {
GURL expectedUrl("http://www.testurl.net");
NSString* expectedTitle = @"title";
@@ -472,12 +473,12 @@ TEST_F(BrowserViewControllerTest, TestSharePageCommandHandling) {
shareToDelegate:bvc_
fromRect:[bvc_ testing_shareButtonAnchorRect]
inView:[OCMArg any]];
- [bvc_ chromeExecuteCommand:GetCommandWithTag(IDC_SHARE_PAGE)];
+ [bvc_.browserCommandDispatcher sharePage];
EXPECT_OCMOCK_VERIFY(shareControllerMock);
}
// Verifies that BVC does not invoke -shareURL on ShareController in response
-// to the IDC_SHARE_PAGE command if tab is in the process of being closed.
+// to the |-sharePage| command if tab is in the process of being closed.
TEST_F(BrowserViewControllerTest, TestSharePageWhenClosing) {
GURL expectedUrl("http://www.testurl.net");
NSString* expectedTitle = @"title";
@@ -498,7 +499,7 @@ TEST_F(BrowserViewControllerTest, TestSharePageWhenClosing) {
shareToDelegate:bvc_
fromRect:[bvc_ testing_shareButtonAnchorRect]
inView:[OCMArg any]];
- [bvc_ chromeExecuteCommand:GetCommandWithTag(IDC_SHARE_PAGE)];
+ [bvc_.browserCommandDispatcher sharePage];
EXPECT_OCMOCK_VERIFY(shareControllerMock);
}
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | ios/chrome/browser/ui/commands/browser_commands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698