Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Issue 2965963002: [ios] Remove IDC_STOP and IDC_RELOAD
Patch Set: Rebased. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/tools_menu/tools_popup_controller.h ('k') | ios/chrome/browser/web/cache_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
index 96928dc03f7cfada72da0219b9c76e1095f26ba5..eb75552b60cdb5e164050b41ff1ff83492765efe 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
@@ -46,11 +46,16 @@ NS_INLINE UIEdgeInsets TabHistoryPopupMenuInsets() {
@implementation ToolsPopupController
@synthesize isCurrentPageBookmarked = _isCurrentPageBookmarked;
-- (instancetype)initWithConfiguration:(ToolsMenuConfiguration*)configuration {
+- (instancetype)initWithConfiguration:(ToolsMenuConfiguration*)configuration
+ dispatcher:(id<BrowserCommands>)dispatcher {
DCHECK(configuration.displayView);
self = [super initWithParentView:configuration.displayView];
if (self) {
+ // Set superclass dispatcher property.
+ self.dispatcher = dispatcher;
_toolsMenuViewController = [[ToolsMenuViewController alloc] init];
+ _toolsMenuViewController.dispatcher = self.dispatcher;
+
_toolsTableViewContainer = [_toolsMenuViewController view];
[_toolsTableViewContainer layer].cornerRadius = 2;
[_toolsTableViewContainer layer].masksToBounds = YES;
@@ -184,7 +189,7 @@ NS_INLINE UIEdgeInsets TabHistoryPopupMenuInsets() {
case IDC_OPTIONS:
base::RecordAction(UserMetricsAction("MobileMenuSettings"));
break;
- case IDC_RELOAD:
+ case TOOLS_RELAOD_ITEM:
base::RecordAction(UserMetricsAction("MobileMenuReload"));
break;
case IDC_SHARE_PAGE:
@@ -208,7 +213,7 @@ NS_INLINE UIEdgeInsets TabHistoryPopupMenuInsets() {
case IDC_SHOW_OTHER_DEVICES:
base::RecordAction(UserMetricsAction("MobileMenuRecentTabs"));
break;
- case IDC_STOP:
+ case TOOLS_STOP_ITEM:
base::RecordAction(UserMetricsAction("MobileMenuStop"));
break;
case IDC_PRINT:
« no previous file with comments | « ios/chrome/browser/ui/tools_menu/tools_popup_controller.h ('k') | ios/chrome/browser/web/cache_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698