Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Issue 2965963002: [ios] Remove IDC_STOP and IDC_RELOAD
Patch Set: Rebased. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
diff --git a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
index e144020eeadf8452ff34d19346b6d0fda871d53e..c5902a5fc67fc40488b5fbc077455f09a5c2d457 100644
--- a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
+++ b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
@@ -484,8 +484,6 @@ CGRect RectShiftedDownAndResizedForStatusBar(CGRect rect) {
// Assign tags before calling -setUpButton, since only buttons with tags
// have -chromeExecuteCommand added as a target.
- [_reloadButton setTag:IDC_RELOAD];
- [_stopButton setTag:IDC_STOP];
[_starButton setTag:IDC_BOOKMARK_PAGE];
[_voiceSearchButton setTag:IDC_VOICE_SEARCH];
@@ -536,6 +534,14 @@ CGRect RectShiftedDownAndResizedForStatusBar(CGRect rect) {
hasDisabledImage:YES
synchronously:NO];
[_stopButton setHidden:YES];
+
+ // Assign targets for buttons using the dispatcher.
+ [_stopButton addTarget:self.dispatcher
+ action:@selector(stopLoading)
+ forControlEvents:UIControlEventTouchUpInside];
+ [_reloadButton addTarget:self.dispatcher
+ action:@selector(reload)
+ forControlEvents:UIControlEventTouchUpInside];
} else {
[_forwardButton setAlpha:0.0];
}
« no previous file with comments | « ios/chrome/browser/ui/toolbar/toolbar_controller.mm ('k') | ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698