Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2965943002: [ios] Remove IDC_BACK and IDC_FORWARD
Patch Set: Rebase, self review. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/browser_view_controller_dependency_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index f38b972e1e7d110dd6eec72cfccf99620852bfb6..a91e0aab568d2565d5bfbb8fccbcbf6958439746 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -1791,7 +1791,8 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
_toolbarController = [_dependencyFactory
newWebToolbarControllerWithDelegate:self
urlLoader:self
- preloadProvider:_preloadController];
+ preloadProvider:_preloadController
+ dispatcher:self.browserCommandDispatcher];
[_dispatcher startDispatchingToTarget:_toolbarController
forProtocol:@protocol(OmniboxFocuser)];
[_toolbarController setTabCount:[_model count]];
@@ -4012,6 +4013,16 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
return card;
}
+#pragma mark - BrowserCommands
+
+- (void)goBack {
+ [[_model currentTab] goBack];
+}
+
+- (void)goForward {
+ [[_model currentTab] goForward];
+}
+
#pragma mark - Command Handling
- (IBAction)chromeExecuteCommand:(id)sender {
@@ -4022,9 +4033,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
Tab* currentTab = [_model currentTab];
switch (command) {
- case IDC_BACK:
- [[_model currentTab] goBack];
- break;
case IDC_BOOKMARK_PAGE:
[self initializeBookmarkInteractionController];
[_bookmarkInteractionController
@@ -4060,9 +4068,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
case IDC_FIND_UPDATE:
[self searchFindInPage];
break;
- case IDC_FORWARD:
- [[_model currentTab] goForward];
- break;
case IDC_FULLSCREEN:
NOTIMPLEMENTED();
break;
« no previous file with comments | « no previous file | ios/chrome/browser/ui/browser_view_controller_dependency_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698