Issue 2855263002: Mojo bindings: support generating identifers using different style rules for different target langu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2855263002: Mojo bindings: support generating identifers using different style rules for different target langu…

Created:
3 years, 7 months ago by yzshen1

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo bindings: support generating identifers using different style rules for different target languages. For example, mapping a mojom struct field "foo_field" to "foo_field" in C++ and "fooField" in JavaScript. This CL adds a Stylizer class and overrides it to specify style rules for JavaScript. This CL also avoids repeatedly computing extra info (version, layout, etc.) for structs/unions/interfaces. BUG=None

Patch Set 1 #

Patch Set 2 : . #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+347 lines, -189 lines)			Patch
M	mojo/public/tools/bindings/generators/js_templates/enum_definition.tmpl	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl	View	1	9 chunks	+85 lines, -70 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl	View	1	2 chunks	+11 lines, -10 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl	View	1	8 chunks	+24 lines, -17 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl	View	1	9 chunks	+27 lines, -24 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/mojom_cpp_generator.py	View	1	4 chunks	+8 lines, -9 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/mojom_java_generator.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/mojom_js_generator.py	View	1	8 chunks	+42 lines, -24 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/generate/generator.py	View	1	8 chunks	+59 lines, -23 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/generate/module.py	View	1	15 chunks	+73 lines, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/generate/translate.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom_tests/generate/generator_unittest.py	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download