Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 2826323003: Re-enable OOPIF scroll bubbling test, limit to non-animated scroll. (Closed)

Created:
3 years, 8 months ago by wjmaclean
Modified:
3 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable OOPIF scroll bubbling test, limit to non-animated scroll. This CL re-enables SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest by limiting it to non-scroll animation cases by specifying has_precise_scroll_deltas. The test is still disabled on CrOS due to an unresolved issue with DCHECKs in RenderWidgetHostImpl. BUG=627238 TBR=creis@chromium.org Review-Url: https://codereview.chromium.org/2826323003 Cr-Commit-Position: refs/heads/master@{#466024} Committed: https://chromium.googlesource.com/chromium/src/+/417b02487720537a5a57f967ddcd67e09083d236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
wjmaclean
Landing TBR as discussed oob, re-land of previously reverted CL https://codereview.chromium.org/2818733002/
3 years, 8 months ago (2017-04-20 15:08:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826323003/1
3 years, 8 months ago (2017-04-20 15:08:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/417b02487720537a5a57f967ddcd67e09083d236
3 years, 8 months ago (2017-04-20 15:50:17 UTC) #8
Charlie Reis
3 years, 8 months ago (2017-04-20 16:35:55 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698