Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2740133002: Mark sub-frame root layer non-fast scrollable when wheel handlers present. (Closed)

Created:
3 years, 9 months ago by wjmaclean
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, blink-reviews-api_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, piman+watch_chromium.org, blink-reviews-frames_chromium.org, kinuko+watch, Charlie Reis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark sub-frame root layer non-fast scrollable when wheel handlers present. Just like with touch event handlers, at present a sub-frame's compositor does not receive regions rects for non-fast scrollable regions that accompany MouseWheel handlers. Until ScrollingCoordinator is made per-frame, we should mark the entire root layer rect as non-fast scrollable in the presence of blocking wheel handlers. The primary changes are all in render_widget_compositor.cc; other files are touched only to give the function a more inclusive name. BUG=698195 Review-Url: https://codereview.chromium.org/2740133002 Cr-Commit-Position: refs/heads/master@{#456131} Committed: https://chromium.googlesource.com/chromium/src/+/47b1b819e0e239b1c753ae4e736f77ac9ccafcdd

Patch Set 1 #

Patch Set 2 : Add (initial draft of) a test. #

Patch Set 3 : Add missing test file. #

Patch Set 4 : Add mainframe version of test for verification. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -15 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 2 3 1 chunk +148 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +14 lines, -3 lines 0 comments Download
A content/test/data/page_with_scrollable_div.html View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (23 generated)
wjmaclean
avi@ - This is a relatively straightforward CL (except perhaps the test) ... do you ...
3 years, 9 months ago (2017-03-10 16:20:32 UTC) #15
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-10 16:40:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740133002/50001
3 years, 9 months ago (2017-03-10 19:07:17 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/383049)
3 years, 9 months ago (2017-03-10 19:14:15 UTC) #24
haraken
WebKit owner LGTM
3 years, 9 months ago (2017-03-10 19:15:55 UTC) #25
wjmaclean
On 2017/03/10 19:15:55, haraken wrote: > WebKit owner LGTM Thanks haraken@ !
3 years, 9 months ago (2017-03-10 19:17:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740133002/50001
3 years, 9 months ago (2017-03-10 19:18:50 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 19:25:20 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/47b1b819e0e239b1c753ae4e736f...

Powered by Google App Engine
This is Rietveld 408576698