Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2581203002: Move call to didRemoveAllEventHandlers out of loop. (Closed)

Created:
4 years ago by wjmaclean
Modified:
4 years ago
Reviewers:
bokan, dtapuska
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move call to didRemoveAllEventHandlers out of loop. EventHandlerRegistry::didRemoveAllEventHandlers() internally loops over all EventHandlerClasses, so including it inside the for loop here is redundant. BUG= Committed: https://crrev.com/0a42552950af63be369e906f95c1eab1f767e3a0 Cr-Commit-Position: refs/heads/master@{#439189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
dtapuska
On 2016/12/16 18:19:13, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years ago (2016-12-16 18:26:08 UTC) #5
dtapuska
bokan@ can you RS
4 years ago (2016-12-16 18:26:28 UTC) #7
bokan
rs lgtm
4 years ago (2016-12-16 20:49:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581203002/1
4 years ago (2016-12-16 20:54:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 21:05:59 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-16 21:09:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a42552950af63be369e906f95c1eab1f767e3a0
Cr-Commit-Position: refs/heads/master@{#439189}

Powered by Google App Engine
This is Rietveld 408576698