RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG=645917
Committed: https://crrev.com/2a6cab73e4df91520c0cbcaacd9ee861dae7805b
Cr-Commit-Position: refs/heads/master@{#429657}

[wjmaclean, 2016-11-03 15:02:58]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[wjmaclean, 2016-11-03 15:03:08]

Description was changed from

==========
RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG=645917
==========

to

==========
RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG=645917
==========

[wjmaclean, 2016-11-03 15:03:08]

wjmaclean@chromium.org changed reviewers:
+ lfg@chromium.org

[wjmaclean, 2016-11-03 15:03:26]

lfg@ - did you want to take a first-look at this?

[commit-bot: I haz the power, 2016-11-03 15:03:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 15:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 15:45:51]

Dry run: This issue passed the CQ dry run.

[lfg, 2016-11-03 16:21:54]

On 2016/11/03 15:03:26, wjmaclean wrote:
> lfg@ - did you want to take a first-look at this?

lgtm -- the RenderFrameImpl is destroyed in frameDetached(), which is called
from WebViewImpl::close(), which is when the RenderViewImpl reference is
balanced.

Even though this is a content change, let's get dcheng@ to review it first,
since the lifetime is managed mostly in blink.

[wjmaclean, 2016-11-03 16:23:59]

wjmaclean@chromium.org changed reviewers:
+ dcheng@chromium.org

[wjmaclean, 2016-11-03 16:24:32]

dcheng@ - this is a fairly small refactor ... can you take a look?

[dcheng, 2016-11-03 17:28:11]

This looks reasonable to me, but I'm not an owner. Also, do you know why this
was historically a weakptr?

[lfg, 2016-11-03 17:32:34]

On 2016/11/03 17:28:11, dcheng wrote:
> This looks reasonable to me, but I'm not an owner. Also, do you know why this
> was historically a weakptr?

This was changed in
https://chromium.googlesource.com/chromium/src/+/abc501eda14b3f1049195e0ccee0...
to do a null-check when destroying PepperPluginInstanceImpl.
PepperPluginInstanceImpl is now associated with a RenderFrame, so that check
doesn't apply anymore.

[wjmaclean, 2016-11-03 17:47:08]

wjmaclean@chromium.org changed reviewers:
+ avi@chromium.org

[wjmaclean, 2016-11-03 17:47:34]

avi@ - could you do an OWNER's review on this? It's small ...

[Avi (use Gerrit), 2016-11-03 18:27:16]

lgtm

[wjmaclean, 2016-11-03 18:28:03]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:29:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 18:37:24]

Description was changed from

==========
RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG=645917
==========

to

==========
RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG=645917
==========

[commit-bot: I haz the power, 2016-11-03 18:37:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 18:45:37]

Description was changed from

==========
RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG=645917
==========

to

==========
RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG=645917

Committed: https://crrev.com/2a6cab73e4df91520c0cbcaacd9ee861dae7805b
Cr-Commit-Position: refs/heads/master@{#429657}
==========

[commit-bot: I haz the power, 2016-11-03 18:45:39]

Patchset 1 (id:??) landed as
https://crrev.com/2a6cab73e4df91520c0cbcaacd9ee861dae7805b
Cr-Commit-Position: refs/heads/master@{#429657}