Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2433943003: Disable (temporarily) WebView Browsertests on Mac build bots. (Closed)

Created:
4 years, 2 months ago by wjmaclean
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable (temporarily) WebView Browsertests on Mac build bots. In order to investigate the causes of the windows-server crashes on the Mac bots, this CL temporarily disables WebView browsertests on Mac. Once their impact is better understood, they will be re-enabled. This CL is related to https://codereview.chromium.org/2414813002 which just disabled the WebUI WebView browser tests. BUG=653353 Committed: https://crrev.com/0cfb5638a524e3bd0ce25d8bc5ab4c7187b3ab5e Cr-Commit-Position: refs/heads/master@{#426254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
wjmaclean
Disabling more WebView browser tests on Mac. Please take a quick look?
4 years, 2 months ago (2016-10-19 15:45:39 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-19 17:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433943003/1
4 years, 2 months ago (2016-10-19 18:02:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 19:00:34 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0cfb5638a524e3bd0ce25d8bc5ab4c7187b3ab5e Cr-Commit-Position: refs/heads/master@{#426254}
4 years, 2 months ago (2016-10-21 13:10:30 UTC) #8
wjmaclean
4 years, 1 month ago (2016-11-03 17:35:44 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2468423005/ by wjmaclean@chromium.org.

The reason for reverting is: This patch was only meant to be temporary. Time to
re-enable the tests..

Powered by Google App Engine
This is Rietveld 408576698